Repository navigation
fix(ci): conventional generated-TF commits and bot-safe session names - #142
Merged
Merged
Conversation
expand pushed '[skip ci] Update generated Terraform from app.yaml' to app branches, which fails commit-message checks in app repos (Conventional Commits), blocking pushes to PR branches that contain it. [skip ci] anywhere in the message still skips workflows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The session name is built from GITHUB_ACTOR, and bot actors such as javabin-platform[bot] or renovate[bot] contain brackets, which STS rejects: the registry's teams-changed dispatch run failed on it, and Renovate-triggered app deploys would too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Alexanderamiri
changed the title
Terraform Plan✅ No changes — infrastructure is up to date. Plan output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes found while rolling out cupcake.
Why
expandpushes[skip ci] Update generated Terraform from app.yamlto app branches, including PR branches. Repos that enforce Conventional Commits then reject any push to a branch containing it; this blocked a follow-up push to frosting#249.GITHUB_ACTOR. Bot actors contain brackets, which STS rejects. The registry'steams-changeddispatch run failed this way (javabin-platform[bot]-…, run 40029013159), and Renovate-triggered app deploys would fail the same way.What changed
chore(terraform): update generated Terraform from app.yaml [skip ci].[skip ci]anywhere in the message still skips workflows.tr -c 'A-Za-z0-9+=,.@_\n-' '-'in tf-plan, docker-build, ecs-deploy and platform-ci.Checks
actionlint, plus a manual check of the sanitizer on the failing name:
javabin-platform-bot--6bd5143d-40029013159.🤖 Generated with Claude Code