Set common-page-size to 16384 for android builds #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested by (@BugsBeGone): java-native-access#1647 (comment) java-native-access#1647 (comment) Supported by: https://issuetracker.google.com/issues/372503468#comment1 https://archive.fosdem.org/2024/events/attachments/fosdem-2024-2340-linker-scripts-in-lld-and-how-they-compare-with-gnu-ld/slides/22752/Fosdem_linker_scripts_2024_uG7XLOI.pdf Closes: java-native-access#1647
matthiasblaesing
force-pushed
the
common_page_size_android
branch
from
68028d4 to
0793e8b
Compare
|
LGTM. I've tested with a 16KB x64 image, and a real Nexus 7 (armeabi-v7a) just to make sure the global use of larger pages doesn't break support on 32-bit devices. |
|
@BugsBeGone thanks again. I could now check with emulator on x86-64 (worked before), but also aarch64 (thanks for the instructions). Lets get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by (@BugsBeGone):
Supported by:
https://issuetracker.google.com/issues/372503468#comment1 https://archive.fosdem.org/2024/events/attachments/fosdem-2024-2340-linker-scripts-in-lld-and-how-they-compare-with-gnu-ld/slides/22752/Fosdem_linker_scripts_2024_uG7XLOI.pdf
Closes: #1647