Attach proper location to return instructions #1094
+283
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgregoir
reviewed
Mar 14, 2025
compiler/src/prog.ml
Outdated
| @@ -123,7 +123,7 @@ type ('len,'info,'asm) gfunc = { | |||
| f_body : ('len,'info,'asm) gstmt; | |||
| f_tyout : 'len gty list; | |||
| f_outannot : Annotations.annotations list; (* annotation attach to return type *) | |||
| f_ret : 'len gvar_i list | |||
| f_ret : 'len gvar_i list L.located | |||
There was a problem hiding this comment.
I have the impression that the change will be much smaller if you add the location in the field f_outannot.
Something like f_outannot : L.t * Annotations.annotations list;
This will allow to not have to patch all occurence of f_ret.
Then maybe f_outannot is not a good name anymore and can renamed.
There was a problem hiding this comment.
Thanks for this good advice. I’ve just implemented it.
vbgl
force-pushed
the
add-iinfo-to-return
branch
from
93c733f to
857a1cb
Compare
vbgl
force-pushed
the
add-iinfo-to-return
branch
from
857a1cb to
8e9b2cd
Compare
vbgl
force-pushed
the
add-iinfo-to-return
branch
from
8e9b2cd to
373b423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #777.