Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to MC#1256 #1093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adapt to MC#1256 #1093

wants to merge 1 commit into from

Conversation

Tragicus
Copy link

@Tragicus Tragicus commented Mar 13, 2025

math-comp/math-comp#1256 changes the behavior of rewrite (seemingly because it generalizes some operations). This PR makes the necessary changes to keep compiling. lia also does not like at all the change in the hierarchy.

@vbgl
Copy link
Member

vbgl commented Mar 13, 2025

Can you please elaborate why these changes are necessary?

In particular, the fact that this breaks lia suggests that the change to mathcomp is wrong.

@Tragicus
Copy link
Author

lia is very fragile with respect to chains of coercions. Actually, I did not introduce more lia breakage. I could do a similar fix to memory_model.v/l.912 but it would not be backwards-compatible since I need to speak about structures that are introduced in my PR.
There is a similar issue with rewrite, where sometimes it does not find the pattern we want because of a chain of coercions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants