Enable compilation on Solaris #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes allow Blink to be built with the default configuration on Solaris, tested on a Solaris 11.4 VM. The main addition is to introduce emulation of flock with fcntl, since the former is not available on new Solaris versions. Additionally, fd_set handling is modified to use heap memory instead of stack memory, since this can exceed the frame size.
the lock exits, all its locks are released. This makes it difficult for us to implement a flock command line replacement simply with fcntl, but we can instead use O_CREAT and O_EXCL to simulate locking with a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow Blink to be built with the default configuration on Solaris, tested on a Solaris 11.4 VM. The main addition is to introduce emulation of flock with fcntl, since the former is not available on new Solaris versions.
Additionally, fd_set handling is modified to use heap memory instead of stack memory, since this can exceed the frame size.