Skip to content

node-cache - chore: (breaking) upgrading hookified adding stats#1609

Merged
jaredwray merged 3 commits intomainfrom
node-cache---chore-(breaking)-upgrading-hookified
Mar 27, 2026
Merged

node-cache - chore: (breaking) upgrading hookified adding stats#1609
jaredwray merged 3 commits intomainfrom
node-cache---chore-(breaking)-upgrading-hookified

Conversation

@jaredwray
Copy link
Copy Markdown
Owner

@jaredwray jaredwray commented Mar 27, 2026

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
node-cache - chore: (breaking) upgrading hookified

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the hookified dependency from version 1 to 2 within the node-cache package, updating the package.json and lockfile. The README.md has been updated to outline key breaking changes such as property renames and configuration removals. A review comment suggests improving the documentation by linking directly to the hookified changelog file for better developer experience.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a850cb7882

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8ac7cbf) to head (e19f90d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1609   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2438      2485   +47     
  Branches       548       556    +8     
=========================================
+ Hits          2438      2485   +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray jaredwray changed the title node-cache - chore: (breaking) upgrading hookified node-cache - chore: (breaking) upgrading hookified adding stats Mar 27, 2026
@jaredwray jaredwray merged commit 6292b97 into main Mar 27, 2026
10 checks passed
@jaredwray jaredwray deleted the node-cache---chore-(breaking)-upgrading-hookified branch March 27, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant