Fix convert_to_utf8 build failure on systems where python3 is not in /usr/bin#32
Open
thegushi wants to merge 1 commit into
Open
Fix convert_to_utf8 build failure on systems where python3 is not in /usr/bin#32thegushi wants to merge 1 commit into
thegushi wants to merge 1 commit into
Conversation
scripts/convert_to_utf8 had a hardcoded #!/usr/bin/python3 shebang which fails on FreeBSD and other systems where Python 3 lives in /usr/local/bin. - Change shebang to #!/usr/bin/env python3 for portability - Add PYTHON= @python@ to templates/Makefile.in and invoke the script via $(PYTHON) so the build uses the exact interpreter detected by configure, consistent with all other Makefiles in the tree
thegushi
force-pushed
the
fix/convert-to-utf8-python-path
branch
from
92eae45 to
d37bb86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/convert_to_utf8has a hardcoded#!/usr/bin/python3shebang, which fails on FreeBSD and other systems where Python 3 lives under/usr/local/bin. The build dies in thetemplates/step withexec(../scripts/convert_to_utf8): No such file or directory.Two changes:
#!/usr/bin/env python3for portabilityPYTHON= @PYTHON@totemplates/Makefile.inand invoke the script as$(PYTHON) ../scripts/convert_to_utf8so the build always uses the interpreter detected byconfigure, consistent with every otherMakefile.inin the tree