-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRACE-1L/2L-OAM models #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
- fix outdated phonondb_pbe_103_structures URL in data-files.yml - simplify file path handling in hpc.py and test_hpc.py
- rename grace2l-r6.yml to grace-2L-mptrj.yml - rename GRACE-(1|2)L-OAM model YAML files to grace-(1|2)l-oam.yml - update Model enum in data.py to include new GRACE model paths
- with argparse for passing models, symprec values to analyze and debug mode - Add example usage in script docstring
for more information, see https://pre-commit.ci
thanks for the new models! impressive performance! 👍 this PR is almost ready to go. need to figure out an issue that snuck in while adding multiprocessing to |
- uses ProcessPoolExecutor - add CLI option for specifying number of worker processes - improve logging and progress tracking
- add figshare pred_file_url for geo_opt, discovery and kappa_103 in grace-1L-oam.yml and grace-2L-oam.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These models were pre-trained on OMat24 and then finetuned on sAlex+MPTraj
prediction artifacts are shared at https://ruhr-uni-bochum.sciebo.de/s/Kl4n9TMnw1JjmOd