fix multi select error never shown #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jannikbuschke , I fixed a small issue for multi select error not shown when submit, hope for your approval |
|
Hi @jannikbuschke |
wbarcovsky
reviewed
Nov 1, 2021
| } | ||
| const hasError = error !== undefined && isTouched | ||
| const hasInitialError = initialError !== undefined | ||
| const isValid = !error && isTouched | ||
| const showHelp = | ||
| hasError || | ||
| (hasInitialError && (!isTouched || showInitialErrorAfterTouched)) | ||
| console.log('Line 36', showHelp, error, isTouched) |
There was a problem hiding this comment.
@linchen2chris Seems like debug code, that should be removed
|
@linchen2chris please update your merge request, this bug is annoying, let's get rid of this. |
|
Ill try to close this this weekend |
|
@allcontributors add linchen2chris for code |
|
I've put up a pull request to add @linchen2chris! 🎉 |
|
I used the code here in commit 11269b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a field is array of string/number, when submit formik will set its
isTouchedto [], then formik-antd will set it to 'false' and its error will never shown.