docs(codeviz): add hyperframes timelapse/review-walkthrough export capability#189
Open
jankneumann wants to merge 2 commits into
Open
docs(codeviz): add hyperframes timelapse/review-walkthrough export capability#189jankneumann wants to merge 2 commits into
jankneumann wants to merge 2 commits into
Conversation
…pability Add a Phase 5 capability (timelapse-review-export) that adopts hyperframes (heygen-com/hyperframes) as a deterministic MP4 export/render layer over the SPA's URL-encoded views. Renders scrub-export timelapses across a commit range and templated review-walkthroughs driven by diff-graph.json (change-kind classification, call/dataflow network evolution, validation badges). Driven headlessly via the Action API; local-first with opt-in cloud render. Also amend spa-scaffold-render to score "deterministic headless capture" (frame-reproducibility under headless Chrome) as a prototype criterion, so the still-open renderer decision does not foreclose downstream video export. Mirrors the change into both proposal copies and the roadmap DAG; new item depends on temporal-snapshot-scrubber, diff-overlay-render, action-api-for-agents, and saved-views-url-state. https://claude.ai/code/session_01WXGawdB7WhwrRHVx4XBhNv
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d0ea2e68c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| render; the core render path MUST work offline. | ||
| - The export MUST be invocable headlessly via the Action API and classified read by the shared op_reversibility | ||
| classifier (it produces an artifact and mutates no graph state). | ||
| - Rendered walkthroughs MUST be written as event-class artifacts under docs/codeviz/walkthroughs/<YYYY-MM-DD>/<run-id>.mp4 |
There was a problem hiding this comment.
This acceptance criterion directs agents to write the rendered .mp4 under docs/codeviz/..., but the same proposal's storage policy says committed artifacts must be small/diffable and caps per-PR Git additions at 1 MB, while larger non-diffable payloads belong in object storage or a local file cache. Review walkthrough MP4s will commonly exceed that cap and are binary, so following this roadmap item will make implementations commit large generated videos; keep only the reproducibility sidecar/manifest in docs/ and put the MP4 itself in the operational artifact tier.
Useful? React with 👍 / 👎.
Pressure-tested the hyperframes capability with the iterate-on-plan finding taxonomy (adapted: codeviz is a roadmap, not an openspec change, so analysis runs against proposal.md + roadmap.yaml and validates via YAML/DAG checks). Resolved assumption (via user decision): the exporter uses a STANDALONE capture composition fed by the HTTP API + diff-graph.json with its own deterministic Canvas2D/SVG path, not the embedded production SPA renderer. Findings addressed: - [high] consistency: rendered MP4s no longer committed to git; moved to the operational storage tier (gitignored cache) per the storage-tier policy. Only the small header-bearing sidecar JSON stays a committed event artifact. - [high] security: untrusted repo-derived strings (commit messages, symbol names, diff text) must be escaped before injection into the headless-Chrome composition; render context network-isolated; surface added to threat model. - [medium] performance: bounded render via configurable max-frame budget with commit-sampling for long histories (mirrors the >50-commit mini-map). - [medium] consistency: export reclassified read -> reversible-write (produces a deletable artifact) and must emit an audit event. - [medium] completeness: dependency edges corrected to http-api-server + diff-graph-artifact (data sources); diff-overlay-render dropped. - [high] assumption cascade: corrected the now-false "gates timelapse-export" claim on spa-scaffold-render; the deterministic-headless-capture criterion is re-anchored to the Action API reproducible-screenshot requirement. https://claude.ai/code/session_01WXGawdB7WhwrRHVx4XBhNv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Phase 5 capability (timelapse-review-export) that adopts hyperframes
(heygen-com/hyperframes) as a deterministic MP4 export/render layer over the
SPA's URL-encoded views. Renders scrub-export timelapses across a commit range
and templated review-walkthroughs driven by diff-graph.json (change-kind
classification, call/dataflow network evolution, validation badges). Driven
headlessly via the Action API; local-first with opt-in cloud render.
Also amend spa-scaffold-render to score "deterministic headless capture"
(frame-reproducibility under headless Chrome) as a prototype criterion, so the
still-open renderer decision does not foreclose downstream video export.
Mirrors the change into both proposal copies and the roadmap DAG; new item
depends on temporal-snapshot-scrubber, diff-overlay-render, action-api-for-agents,
and saved-views-url-state.
https://claude.ai/code/session_01WXGawdB7WhwrRHVx4XBhNv