Implemented CMake build system #9
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi J. Andrew Rogers,
I want to thank you for implementing the MetroHash library,
because it's being used extensively in the AMD Vulkan driver:
At AMD, we are working on refactoring the AMDVLK CMake build system,
during which I've implemented CMake build system for the MetroHash library.
This merge request proposes:
Reorganization of MetroHash directory structure, isolating its interface from its implementation.
Simple, clean and robust CMake builds system.
I want to emphasise that this change is not AMD specific.
Its goal is to improve robustness of the MetroHash library, in terms of integration it with large C++ projects.
I don't know how this change fits with your plans of introducing MetroHash v2
and what is your take on backward compatibility:
Do you prefer gradual changes or one hard breakage?
What kind of changes are you planning for MetroHash v2?
When do you think MetroHash v2 will be released?
I am asking, because I want to propose changes,
which make sense in the context of your plans and to be prepared for upcoming changes.