Fix Session store not set on request #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the error in
vendor/laravel/framework/src/Illuminate/Http/Request.php:560when the request does not have a session. This happens to me when I use the package with Laravel Passport.The previous evaluation was incorrect since if the request does not have a session but the configuration variable is not "off" it still evaluates to false and the execution of the code continues.
With the change I made in this PR the execution of the code will continue only when the request has a session and config('timezone.flash') is not "off".
Setting the config('timezone.flash') to "off" also fixes the problem as mentioned here but i think is not the right solution for the problem: #59 (comment)