Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better performance in RemoveEntries #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better performance in RemoveEntries #63

wants to merge 2 commits into from

Conversation

thomas694
Copy link
Contributor

  • Instead of decompressing and recompressing the data, it is simply copied into the new zip file.

Fixes #59

@thomas694
Refactor RemoveEntries
7de3f88 
- Instead of decompressing and recompressing the data, it is simply copied into the new zip file.
@thomas694
Fix issue RemoveEntries fails due to missing filename
478fef0 
- For archives created/opened with a file stream the filename isn't set thus RemoveEntries failed.
@thomas694
Copy link
Contributor Author

I missed that the Create/Open methods with stream parameters in case of FileStreams, which will be the most common stream type, do not set the filename field.
So RemoveEntries failed in these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better performance in RemoveEntries
1 participant
@thomas694