Change reqwest dependency against ureq
#117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes `reqwest`, and its transitive dependencies like `tokio`, and uses `ureq` instead. The latter library uses `curl` as HTTP client. `libcurl` should be installed by default on all current Windows and MacOS installations, and most likely by all serious Linux distros, too. `libcurl` is only loaded at runtime instead of being a hard dependecy. This way, if `libcurl` is not installed, the program will still run just fine, but the self update will fail. This changes makes the `github` example much smaller: ```text 1808048 github.master 1127536 github.patch -680512 bytes or -38% ``` ```text $ size github.master github.patch text data bss dec filename 1738914 52288 529 1791731 github.master 1078768 31784 465 1111017 github.patch -660146 -20504 -64 -680714 ```
Kijewski
force-pushed
the
pr-ureq
branch
2 times, most recently
from
f764fbb to
052f3b0
Compare
|
bump, any updates regarding merging this? |
|
Can you make this a pair of features to enable either ureq or reqwest? If someone already has tokio in their dep tree, they may prefer using reqwest over depending on libcurl |
Yes, that would have been a good idea from the get-go. Will do, but I cannot tell you an ETA. @CosminPerRam, if you are free, and you are interested, maybe you would like adopt the PR? No pressure if you decide later that you don't want to do the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
reqwest, and its transitive dependencies liketokio, and usesureqinstead. The latter library usescurlas HTTP client.libcurlshould be installed by default on all current Windows and MacOS installations, and most likely by all serious Linux distros, too.libcurlis only loaded at runtime instead of being a hard dependecy. This way, iflibcurlis not installed, the program will still run just fine, but the self update will fail.This changes makes the
githubexample much smaller: