add support for es-tags-as-fields through env #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Montoya <[email protected]>
jam01
force-pushed
the
fix/es-tags-as-fields
branch
from
3137223 to
ec9e957
Compare
vlsi
reviewed
Feb 11, 2025
Comment on lines
+55
to
+57
| Field field = env.getClass().getDeclaredField("m"); | ||
| field.setAccessible(true); | ||
| ((Map<String, String>) field.get(env)).put(name, val); |
There was a problem hiding this comment.
This does not look right, and it will likely make the maintenance harder.
Can we have an alternative way to pass configuration so we don't have to override private fields in java.lang namespace?
vlsi
reviewed
Feb 11, 2025
| @@ -38,9 +43,28 @@ public class SpanDeserializer extends StdDeserializer<Span> { | |||
|
|
|||
| // TODO Spark incorrectly serializes object mapper, therefore reinitializing here | |||
| private ObjectMapper objectMapper = JsonHelper.configure(new ObjectMapper()); | |||
| private final boolean tagsAsFieldsAll; | |||
| private final List<String> tagsAsFields; | |||
There was a problem hiding this comment.
Have you considered Set<String>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes