This repository was archived by the owner on Jul 30, 2020. It is now read-only.
Added InspectorCurveAttribute #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssignment (for example, assemly reload of non-serialized fields).
Collaborator
Author
|
Already stumbled on something. How can I make this work on collections? Currently, it will error out: |
Collaborator
Author
|
I read some of the code and thought I had figured a solution, but failed. What I tried to do was adding a public interface fiICollectionAttributeProvider {
IEnumerable<object> GetAttributes(params object[] attributeArgs);
}Then, in public InspectorCollectionItemAttributesAttribute(Type attributes, params object[] attributeArgs) {
if (typeof(fiICollectionAttributeProvider).Resolve().IsAssignableFrom(attributes.Resolve()) == false) {
throw new ArgumentException("Must be an instance of FullInspector.fiICollectionAttributeProvider", "attributes");
}
var instance = (fiICollectionAttributeProvider)Activator.CreateInstance(attributes);
AttributeProvider = fiAttributeProvider.Create(instance.GetAttributes(attributeArgs).ToArray());
}But it didn't work. public class InspectorMovementCurvesCollection: fiICollectionAttributeProvider {
public IEnumerable<object> GetAttributes(params object[] attributeArgs) {
yield return new InspectorCurveAttribute(0, 0, 10, 10);
}
}Meaning, it would actually use the But, if I instead used Could you shed some light on this, @jacobdufault ? What I ended up doing was to just have a default that matches my current needs public class InspectorMovementCurvesDefault: fiICollectionAttributeProvider {
public IEnumerable<object> GetAttributes() {
yield return new InspectorCurveAttribute();
}
}I'll update the PR with this. |
Owner
|
Any idea why the constructor forwarding approach did not work? I would expect that Is this the usage you were trying to go for? [InspectorCollectionProxy(typeof(InspectorCurveAttribute), 0, 0, 1, 1)]
public LIst<AnimationCurve> entries; |
jacobdufault
reviewed
Dec 4, 2016
|
|
||
| namespace FullInspector.Modules { | ||
| [CustomAttributePropertyEditor(typeof(InspectorCurveAttribute), ReplaceOthers = true)] | ||
| public class InspectorCurveAttributeEditor<TElement> : AttributePropertyEditor<TElement, InspectorCurveAttribute> { |
Owner
There was a problem hiding this comment.
Since AnimationCurve is a sealed class, you don't need to make this editor generic. So
public class InspectorCurveAttributeEditor : AttributePropertyEditor<AnimationCurve, InspectorCurveAttribute> {
| namespace FullInspector.Modules { | ||
| [CustomAttributePropertyEditor(typeof(InspectorCurveAttribute), ReplaceOthers = true)] | ||
| public class InspectorCurveAttributeEditor<TElement> : AttributePropertyEditor<TElement, InspectorCurveAttribute> { | ||
| private static T Cast<T>(object o) { |
Owner
There was a problem hiding this comment.
Not needed when the class is not generic.
|
|
||
|
|
||
| /// <summary> | ||
| /// Uses the default constructor from <see cref="InspectorCurveAttribute" /><br /> |
Owner
There was a problem hiding this comment.
nit: No indentation after ///
(applies to every comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed something like this to restrict curves to a certain range and just whipped this a few minutes ago.
Always impressed with how easy we can do things in FullInspector.
Placed in the
Modulesfolder, sinceInspectorRangeis already there.Would appreciate a quick review before merging.