Limit tool call id to 9 chars for Mistral #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackmpcollins
commented
Jul 28, 2024
Comment on lines
+116
to
+118
| # Mistral requires AssistantMessage after tool output | ||
| # TODO: Automatically add this in ChatModel.complete like for tool calls | ||
| AssistantMessage("."), |
There was a problem hiding this comment.
@mnicstruwig FYI, should only be needed if doing few-shot prompting.
The OpenAI and Mistral APIs are starting to diverge so I've made an issue to switch to using the Mistral python client. #280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit tool call id to 9 chars for Mistral.
Fixes #276
Closes #277