Fix/jsonbarray set json rawmessage #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following jacks comment here, I added
json.RawMessagetotype_array_gen.sh.This will fix the particular case of using
.Seton sources of type[]json.RawMessage. I added tests to confirm this.However, it does not fix the fundamental issue in the sense that any other type alias for
[]bytecan reproduce the errors. I suspect this is due to a bug in thedefaultreflect based case of.Set.Since
json.RawMessageis a type in the standard library, and since the non-reflect cases are more efficient, I thought this little addition may still provide some value.