fix: keep finished-sketch list in history order - #58
Merged
jeffglousher merged 1 commit intoAug 22, 2026
Merged
Conversation
end_sketch now sorts finished by feature-tree index so mid-history inserts match the restore path.
jackControls
approved these changes
Aug 21, 2026
jackControls
left a comment
Owner
There was a problem hiding this comment.
Reviewed the feature-order fix and regression coverage. Sorting finished sketches by feature-tree position correctly handles insertion at a moved build cursor, while unknown IDs remain safely ordered last. The focused solid-history test passes locally. Approved; I did not merge.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end_sketchstill appended tofinishedafter fix: insert sketches and datums at the history cursor #49, so rollback → new sketch → end left the new sketch last infinished_sketches()while the feature tree had it mid-history.finishedby the same key as project restore: index offeature_idindocument.features().features.new_sketch_is_inserted_at_the_build_cursortest now also asserts finished names areSketch1,Sketch3,Sketch2(not append order).Fixes #52.
Test plan
cargo test -p nbcad-sketch --test solid_history— 4 passed, includingnew_sketch_is_inserted_at_the_build_cursor@jackControls please review; do not merge until you sign off.