fix: harden threads, sketch constraints, and modeling history - #47
Merged
Conversation
jeffglousher
approved these changes
Aug 20, 2026
jeffglousher
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Right follow-up to #44 — ISO 6H/6g envelopes match the published limits, external thread stays on an analytic cylinder, and history/preview stay consistent with the owning feature. Approved.
This was referenced Aug 20, 2026
jeffglousher
added a commit
to jeffglousher/noBS-CAD
that referenced
this pull request
Aug 20, 2026
jackControls#47 persists chained H/V as Perpendicular. The raw mm^2 Dot residual then dwarfed the drag pin, LM stalled, and move_point reverted the corner. Normalize Perp to cos(angle) like Parallel already does.
This was referenced Aug 20, 2026
Open
jackControls
pushed a commit
that referenced
this pull request
Aug 20, 2026
#47 persists chained H/V as Perpendicular. The raw mm^2 Dot residual then dwarfed the drag pin, LM stalled, and move_point reverted the corner. Normalize Perp to cos(angle) like Parallel already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Follow-up testing after #44 exposed several production edge cases:
This change keeps exact geometry and feature history authoritative while making preview-only rendering follow the owning model feature.
User impact
Validation
cargo fmt --all -- --checkgit diff --checkcargo test --workspace— 395 passed, 2 ignored