Skip to content

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Jul 2, 2025

I noticed with a purchased model that if you have lots of anim clips, it's desirable for them to be sorted, or it gets very difficult finding the right one.

@neph1 neph1 requested a review from Copilot July 3, 2025 14:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the usability of the scene explorer by sorting animation clips alphabetically and marking legacy animation controls as deprecated.

  • Marked JmeAnimControl and JmeAnimChildren as deprecated.
  • Updated JmeAnimComposerChildren to sort animation clips by name and refactored createNodes to use a pattern‐matching switch.
  • Bumped the copyright year in the file header and added necessary imports.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/animation/JmeAnimControl.java Added @Deprecated annotation on JmeAnimControl class
jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/animation/JmeAnimComposerChildren.java Updated header year, imported Collections, sorted animClips, and refactored createNodes with switch
jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/animation/JmeAnimChildren.java Added @Deprecated annotation on JmeAnimChildren class
Comments suppressed due to low confidence (3)

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/animation/JmeAnimControl.java:58

  • Add a Javadoc @deprecated tag explaining why this class is deprecated and what should be used instead.
@Deprecated

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/animation/JmeAnimComposerChildren.java:89

  • Add a unit test to verify that animation clips are sorted alphabetically as intended.
                    Collections.sort(animClips, (AnimClip a, AnimClip b) -> a.getName().compareTo(b.getName()));

jme3-core/src/com/jme3/gde/core/sceneexplorer/nodes/animation/JmeAnimChildren.java:52

  • Add a Javadoc @deprecated tag to this class to describe the recommended replacement and reason for deprecation.
@Deprecated

neph1 and others added 2 commits July 3, 2025 20:00
@neph1 neph1 merged commit 7229646 into jMonkeyEngine:master Jul 5, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant