Skip to content

Add low-level hook for SDL3 input events#2867

Open
Ivan1pl wants to merge 2 commits into
jMonkeyEngine:masterfrom
Ivan1pl:issue/2864/SDL3-low-level-input-event
Open

Add low-level hook for SDL3 input events#2867
Ivan1pl wants to merge 2 commits into
jMonkeyEngine:masterfrom
Ivan1pl:issue/2864/SDL3-low-level-input-event

Conversation

@Ivan1pl

@Ivan1pl Ivan1pl commented Jun 10, 2026

Copy link
Copy Markdown

Resolves #2864

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the SdlEventListener interface to allow custom listeners to receive raw SDL events, and updates SdlJoystickInput, SdlKeyInput, and SdlMouseInput to implement it. LwjglWindow is updated to manage these listeners and dispatch events. The feedback suggests wrapping the custom listener event dispatch loop in a try-catch block to prevent any unhandled exceptions from interrupting the dispatching of events to subsequent listeners and internal input handlers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add low-level hook for SDL3 input event

1 participant