Clear stale input states when triggers are removed and fix virtual LT/RT buttons in sdl backend#2849
Clear stale input states when triggers are removed and fix virtual LT/RT buttons in sdl backend#2849riccardobl wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies InputManager to clean up bindings, pressed buttons, and axis values when mappings or triggers are deleted, and adds corresponding unit tests to verify that deleted mappings/triggers clear the pressed key state. Additionally, it updates SdlJoystickInput to ignore Xbox LT and RT buttons during button event handling. The reviewer feedback highlights potential NullPointerException risks in both deleteTrigger and deleteMapping if the retrieved mapping list is null, suggesting defensive null checks to prevent crashes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR solves two input related issues: