Mediacopy to sixel file on host #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not yet receive the file, only initiates it on the VT340.
Does not yet receive the file, only initiates it on the VT340.
Does not yet receive the file, only initiates it on the VT340.
|
I didn't want to bother with adding mediacopy to the debug branch because I wasn't planning on keeping any of the debugging code - it was just there to help track down the issues you were seeing. I'm only going to merge in the actual fixes. And no, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds Ctrl-P to the debug build. It works well enough for that purpose but it could be better. In particular, I should convert it to C++ and fit it to your style.
Since it takes a while for the screenshot, it prints a message in the statusbar while it is working. Currently it hangs on systems which do not understand the VT340's Mediacopy to Host escape sequence.
Does
capabilities::_query()handle timeouts when a terminal doesn't respond? I had been using termios in my code, but my understanding is that that doesn't work under Microsoft Windows.