Serve CodeMirror CSS and JS locally. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a configuration option (CODEMIRROR_SERVE_LOCAL, inspired by flask-boostrap's BOOTSTRAP_SERVE_LOCAL) to serve CodeMirror files from flask (they must be placed in <app-static-dir>/codemirror/<version>/...)
j0ack
requested changes
Feb 15, 2018
| CDN_URL = '//cdnjs.cloudflare.com/ajax/libs/codemirror/{0}/' | ||
| LOCAL_PATH = '/codemirror/{0}' |
There was a problem hiding this comment.
I think it should be better if there was a config key for this path, since it's local users could host the scripts where they want.
| if self.serve_local: | ||
| self.base_url = None | ||
| else: | ||
| self.base_url = self.__class__.CDN_URL.format(self.version) |
There was a problem hiding this comment.
Not mandatory since you check self.serve_local later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option (CODEMIRROR_SERVE_LOCAL, inspired by
flask-boostrap's BOOTSTRAP_SERVE_LOCAL) to serve CodeMirror files from
flask (they must be placed in /codemirror//...)