Fix SwiftPM support #342
Closed
Fix SwiftPM support #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for implementing this @bvirlet! I am having a similar issue and confirmed that your fix is working for me. |
|
Hi @iziz. Do you plan to merge this? I have updated my fork with your latest changes (thanks) but the first commit is still needed to prevent the duplicate symbol issues. |
|
Reopened with the just the required commit #358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes:
platformsparameter, so it's incompatible with the annotation// swift-tools-version:4.1. Since you have a fine[email protected]file, I have removed the platform parameters fromPackage.swift. I confirm that this fixes importing the package with SPM 5.3.