Update pod spec file #248
Open
Update pod spec file #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paween
reviewed
Oct 2, 2020
| s.authors = { "iziz" => "[email protected]", "hyukhur" => "[email protected]" } | ||
| s.source = { :git => "https://github.com/iziz/libPhoneNumber-iOS.git", :tag => s.version.to_s } | ||
| s.libraries = 'z' | ||
| s.module_name = "libPhoneNumberiOS" |
There was a problem hiding this comment.
Can you separate the module change and the Cocoapods fix into 2 separate PRs? As one is a fix, and another one is a breaking change. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial change here was to set the module_name so that it matches what Carthage would use (and appears to be what is expected anyway). This would obviously be a breaking change for anyone who's currently using this via CocoaPods, although like I say this appears to be the correct module name anyway.
I also found that the latest version wouldn't actually run with CocoaPods though so tweaked the source_files attribute so that it now compiles.