Changed the product name to 'libPhoneNumber' for all targets #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… target - added modulemap files - not sure if it is better to name the actual product 'libPhoneNumber' or just set the module name to 'libPhoneNumber'
…re is a private Apple API called ‘NBPhoneNumberUtil’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added modulemap files
not sure if it is better to name the actual product 'libPhoneNumber' or just set the module name to 'libPhoneNumber'
I have a workspace with many targets that use watchOS, iOS and macOS
with each one, I have a separate framework created that is specific for each target
it is really, really annoying if I have to deal with the same framework (libPhoneNumber) that has different names (libPhoneNumbermacOS, libPhoneNumberiOS, etc) because that would force me to use if statements to import a framework if a particular name depending on the current target.
I find it easier if the framework name is always the same and just call '@import libPhoneNumber', whether iOS, macOS, watchOS or tvOS
an alternative would be to name the 'moduleName' different from the target name, but I find tat more confusing