Skip to content

Declare @types/node as a dependency #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

leonard-thieu
Copy link
Contributor

Because the type definitions for gulp-typescript exposes declarations from @​types/node, @​types/node must be added as a dependency to ensure consumers will have it.

@ivogabe
Copy link
Owner

ivogabe commented Jun 20, 2017

We've done that in the past, but this sadly causes that @types/node will automatically be added to all compilations using gulp-typescript.. See microsoft/TypeScript#11917. So I personally agree that this should be added, but it would break a lot of users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants