Comments from Mark Taylor added #19
Conversation
Note that the "../v1.3" is correct in the xmlns attribute, even though the VOTable version is 1.5.
There was a problem hiding this comment.
I made a validity fix to the example VOTable in section 5.
Other than that it looks good with one exception: the t_validity field is documented as mandatory, but it does not appear in the example response in section 5. Either downgrade t_validity to optional or add a suitable column to the VOTable.
| confidence of the validity range, with one of the following allowed | ||
| \begin{itemize} | ||
| \item {A numeric field with name="\textbf{t\_validity}" \textbf{MUST} be present | ||
| with utype=" \textbf{Char.TimeAxis.Coverage.Time}" and unit="d", containing the date when the |
There was a problem hiding this comment.
For the second time, I am submitting the same review comment: Please remove the space after utype=".
| @@ -278,40 +279,32 @@ \subsubsection{Required parameters} | |||
|
|
|||
| \begin{itemize} | |||
| \item{\textbf{MAXREC}\\MAXREC parameter is defined in DALI and allows | |||
| the client to limit the number or records in the response. A service | |||
| the client to limit the number of records in the response. A service | |||
| implementation may also impose default and maximum values for this limit. | |||
| However, the limit is determined, if the output is truncated due to the | |||
There was a problem hiding this comment.
| However, the limit is determined, if the output is truncated due to the | |
| However the limit is determined, if the output is truncated due to the |
Since this is a subordinate clause, the comma should appear after the clause and not the subordinating conjunction.
| to check for object observability. The unit of \textbf{TIME} parameter must be | ||
| expressed in MJD. The format of the range list is the one defined by other | ||
| IVOA S*APs protocols like SSAP \citep{std:SSAP}, where the format of a | ||
| IVOA S*APs protocols like SSAP \citep{2012ivoa.spec.0210T}, where the format of a | ||
| range is defined by '$t_{min}\slash t_{max}$'. If the range is defined | ||
| as an open range without the lower value of the range like '$\slash t_{max}$', | ||
| as an open range without the lower value of the range like '$t_{max}$', | ||
| $t_{min}$ will be interpreted as now.\\ |
There was a problem hiding this comment.
I don't think the reference to the other Simple protocols is entirely correct or, at least, may be confusing to the reader.
For TIME:
- SSA does indicate its range-list values this way, with a
/, but uses ISO-8601. - SIA's
TIMEdoes use MJD, but indicates its range-lists with a space.
Maybe it's best to drop the reference entirely? Either place the reader looks, the examples would be incorrect.
There was a problem hiding this comment.
Since RESPONSEFORMAT is implied as being supported in Sec 4.1, perhaps it should be added to the Non-compulsory Parameters section?
| \hline | ||
| \textbf{moon\_sep\_min} & \textbf{(MAY)} & phys.angDist & Minimum | ||
| \textbf{moon\_sep\_min} & \textbf{(MAY)} & & Minimum | ||
| Moon separation for this sky position and observability time interval & | ||
| float & deg \\ |
There was a problem hiding this comment.
It looks like moon_sep_min was missed as a numeric.
| float & deg \\ | |
| numeric & deg \\ |
| @@ -798,7 +760,7 @@ \section{ObjObsSAP data model summary} | |||
| \textbf{em\_min} & \textbf{Char.Spectral.Axis.Energy.Min \newline | |||
| (MAY)} & | |||
| em.energy & Energy minimum for this particular sky position and | |||
| observability time interval & float & m \\ | |||
| observability time interval & numeric & m \\ | |||
There was a problem hiding this comment.
Should em_max be a numeric as well? See moon_sep_min comment.
No description provided.