Pick a different instance upon redirect #5154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
requested changes
Jan 23, 2025
syeopite
added
the
unfinished
SamantazFox
reviewed
Jan 24, 2025
syeopite
reviewed
Jan 25, 2025
src/invidious/routes/misc.cr
Outdated
| @@ -42,12 +42,17 @@ module Invidious::Routes::Misc | |||
| referer = get_referer(env) | |||
|
|
|||
| instance_list = Invidious::Jobs::InstanceListRefreshJob::INSTANCES["INSTANCES"] | |||
| if instance_list.empty? | |||
| # Filter out the current instance | |||
| other_available_instances = instance_list.reject! { |_, domain| domain == CONFIG.domain } | |||
There was a problem hiding this comment.
Suggested change
| other_available_instances = instance_list.reject! { |_, domain| domain == CONFIG.domain } | |
| other_available_instances = instance_list.reject { |_, domain| domain == CONFIG.domain } |
reject! modifies itself instead of creating a new Tuple. other_available_instances isn't necessary unless you're using reject
syeopite
added
need-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the redirect url may redirect the user back to the same instance they are currently on.