Skip to content

Fix warnings in windows and update put functions without validation#8

Merged
olivhoenen merged 4 commits intoiterorganization:developfrom
prasad-sawantdesai:Fix-warnings-in-windows-and-update-put-functions-without-validation
Mar 30, 2026
Merged

Fix warnings in windows and update put functions without validation#8
olivhoenen merged 4 commits intoiterorganization:developfrom
prasad-sawantdesai:Fix-warnings-in-windows-and-update-put-functions-without-validation

Conversation

@prasad-sawantdesai
Copy link
Copy Markdown
Contributor

@prasad-sawantdesai prasad-sawantdesai commented Feb 26, 2026

Validation logic is skipped on windows platform and now compiling code for put and put_slice is not an issue.. Please check #3

  Building Custom Rule C:/Users/sawantp1/IMAS-MATLAB/CMakeLists.txt
  ids_put.c
  put_ids.c
  delete_ids.c
  Generating Code...
cl : command line  warning D9025: overriding '/W1' with '/w' [C:\Users\sawantp1\IMAS-MATLAB\build\mex-ids_put.vcxproj]
  c_mexapi_version.c
     Creating library C:/Users/sawantp1/IMAS-MATLAB/build/Release/ids_put.lib and object C:/Users/sawantp1/IMAS-MATLAB/build/Release/ids_put.exp
  mex-ids_put.vcxproj -> C:\Users\sawantp1\IMAS-MATLAB\build\Release\ids_put.mexw64
  Building Custom Rule C:/Users/sawantp1/IMAS-MATLAB/CMakeLists.txt
  ids_put_slice.c
  put_slice_ids.c
  put_ids.c
  delete_ids.c
  Generating Code...
cl : command line  warning D9025: overriding '/W1' with '/w' [C:\Users\sawantp1\IMAS-MATLAB\build\mex-ids_put_slice.vcxproj]
  c_mexapi_version.c
     Creating library C:/Users/sawantp1/IMAS-MATLAB/build/Release/ids_put_slice.lib and object C:/Users/sawantp1/IMAS-MATLAB/build/Release/ids_put_slice.exp
  mex-ids_put_slice.vcxproj -> C:\Users\sawantp1\IMAS-MATLAB\build\Release\ids_put_slice.mexw64
  Building Custom Rule C:/Users/sawantp1/IMAS-MATLAB/CMakeLists.txt
  ids_rand.c
  rand_ids.c
  Generating Code...
image

@olivhoenen
Copy link
Copy Markdown
Contributor

olivhoenen commented Feb 26, 2026

Please create an issue in github so we don't forget to address this, and add a note in the documentation (that points to the issue) so users are aware of this limitation on windows builds

@prasad-sawantdesai
Copy link
Copy Markdown
Contributor Author

Please create an issue in github so we don't forget to address this, and add a note in the documentation (that points to the issue) so users are aware of this limitation on windows builds

Issue is created here #3
and documentation is added here https://github.com/iterorganization/IMAS-MATLAB/pull/8/changes#diff-db6445315c24cab62edf3e0791db8875e2bfb018555cb5a10cd29f61cae42da3L4

Copy link
Copy Markdown
Contributor

@olivhoenen olivhoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivhoenen olivhoenen merged commit 18c2fb0 into iterorganization:develop Mar 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants