drop Python 3.8 support #10265
Merged
drop Python 3.8 support #10265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this PR only makes typing related changes. Other changes can be done once this gets merged, they are relatively few in numbers.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10265 +/- ##
==========================================
- Coverage 90.47% 90.44% -0.03%
==========================================
Files 493 493
Lines 37682 37723 +41
Branches 5457 5457
==========================================
+ Hits 34092 34119 +27
- Misses 2962 2973 +11
- Partials 628 631 +3 ☔ View full report in Codecov by Sentry. |
2 tasks
BradyJ27
pushed a commit
to BradyJ27/dvc
that referenced
this pull request
Apr 22, 2024
* drop Python 3.8 Note that this PR only makes typing related changes. Other changes can be done once this gets merged, they are relatively few in numbers. * bump build python version * add typing_extensions to lint group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping Python 3.8 support since scmrepo dropped support in iterative/scmrepo#312 (which in turn was a result of pygit2 dropping support).
Many libraries have started dropping support for Python 3.8 now, so it makes sense for dvc to do the same here at this time. Even though 3.8 is 8 months away from getting EOL'd.
Note that this PR only makes typing related changes. Other changes can be done once this gets merged, they are relatively few in numbers.
Most of the changes are auto-upgraded via
pyupgradeandruff.To reproduce, update
requires_pythonto>=3.9. Then, run the following script:Then, a few manual typing changes related to
typing.Type/typing.ContextManagerwhich are deprecated, and addedtyping_extensions.Selfin some places.Also, Python versions in GitHub workflows were updated in relevant places.