Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming object_name to column #1030

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Apr 7, 2025

This PR is a follow up of #1012
Idea is to rename all public appearance of object_name to column

@ilongin ilongin linked an issue Apr 7, 2025 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Apr 7, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5781178
Status: ✅  Deploy successful!
Preview URL: https://9140b4b4.datachain-documentation.pages.dev
Branch Preview URL: https://ilongin-1016-rename-object-n.datachain-documentation.pages.dev

View logs

@ilongin ilongin marked this pull request as draft April 7, 2025 14:25
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (d67d2e9) to head (5781178).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files         145      145           
  Lines       12372    12372           
  Branches     1718     1718           
=======================================
  Hits        10907    10907           
  Misses       1046     1046           
  Partials      419      419           
Flag Coverage Δ
datachain 88.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilongin ilongin marked this pull request as ready for review April 7, 2025 14:41
@ilongin ilongin merged commit 2435dc4 into main Apr 8, 2025
35 checks passed
@ilongin ilongin deleted the ilongin/1016-rename-object-name branch April 8, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'object_name to column
3 participants