-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase MAX_IMPORT_TIME_MS in tests up to 800ms #1018
Conversation
Deploying datachain-documentation with
|
Latest commit: |
3a679d6
|
Status: | ✅ Deploy successful! |
Preview URL: | https://bf7ef275.datachain-documentation.pages.dev |
Branch Preview URL: | https://increase-max-import-time-tes.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1018 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 145 145
Lines 12355 12355
Branches 1713 1713
=======================================
Hits 10889 10889
Misses 1048 1048
Partials 418 418
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@dreadatour why is it happening? is there a chance that we actually making it worse gradually and need to do a research again? |
It is possible, but I have seen this test fails before, many times, and rerun helps. I think this is because of GitHub CI runners, but I am not sure, that's why I have mentioned @skshetry in this PR, I would like to discuss this issue with him before merging this. We also have this discussion before, in this PR: #974 |
What is the max import time we are aiming for? ... Anyway, I would rather skip the test for now and create an issue to fix it, then increasing import time but I don't have strong opinion. |
@skshetry it would be great if we can discuss this 🙏 The test failed here too, as well: https://github.com/iterative/datachain/actions/runs/14367963543/job/40298766582?pr=1035
|
I'd like it to be <100ms, but we are pretty far away from that. |
I know 😥 We'll be there, one day 🤗 |
This test fails too often :(
Latest example: https://github.com/iterative/datachain/actions/runs/14176251298/job/39711770663
Will be happy to have better option and also will be happy to discuss this.