Skip to content

Release share on I/O error. #16994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Release share on I/O error. #16994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions smb/src/main/java/ch/cyberduck/core/smb/SMBReadFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,17 @@ protected void afterRead(final int n) throws IOException {
}
}

@Override
protected void handleIOException(final IOException e) throws IOException {
try {
session.releaseShare(share);
}
catch(BackgroundException ignored) {
// Ignore
}
throw e;
}

@Override
public void close() throws IOException {
try {
Expand Down
11 changes: 11 additions & 0 deletions smb/src/main/java/ch/cyberduck/core/smb/SMBWriteFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,17 @@ protected void afterWrite(final int n) throws IOException {
}
}

@Override
protected void handleIOException(final IOException e) throws IOException {
try {
session.releaseShare(share);
}
catch(BackgroundException ignored) {
// Ignore
}
throw e;
}

@Override
public void close() throws IOException {
try {
Expand Down