-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presentation submission parser implementation and mdoc support #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llet-it-python into feat/mdoc_support
peppelinux
reviewed
Mar 20, 2025
peppelinux
reviewed
Mar 20, 2025
peppelinux
reviewed
Mar 20, 2025
Co-authored-by: Giuseppe De Marco <[email protected]>
…lia/eudi-wallet-it-python into feat/presentation_submission
peppelinux
requested changes
Mar 27, 2025
Comment on lines
+656
to
+657
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #299
Resolves #114
Resolves #392
This PR is relative to #314.
It takes the initial implementation of PresentationSubmission and completely refactor it to be instantiated once with the global config and handle the parsing and the verification.
It also adds the support to the MdocCbor credential format.
This PR also downgrade the version of Ubuntu to 22.04 in the CI relative to the problem described here