Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accordion's arrow orientation #953

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

federico-ntr
Copy link
Contributor

Fixes #

PR Checklist

  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

This PR changes the arrow orientation in the Accordion component, so that it points down when collapsed and up when not.
The accordion is expanded when it has the prop active set to true, so the class collapsed should be set when active === false, but it was the opposite.

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 0:33am

@sabato-galasso sabato-galasso merged commit a27a50c into italia:next Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants