-
Notifications
You must be signed in to change notification settings - Fork 1.6k
adding pt-br to selection menus and i18n configs #16797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: adding-pt-br
Are you sure you want to change the base?
Conversation
This typically comes after the translation? I'm worried about this as it stands the number of docs maintainers we have is very low, do we already have a team that can handle these translations and PR reviews? |
I was basically trying to follow the instructions for translations. I'd expect that we would create a PR into main once we have the translation done in this branch. At the moment we have 3 people (including me) that are willing to work on this. I'd accept other suggestions on how we can progress with an iterative translation. |
I missed this wasn't to the master branch. In the past it's gone through TOC afaik. Unfortunately, on the infra/English side, we're down to essentially 2 people atm. I think Craig was bottomlining the Ukranian translations, but I don't know if I'm comfortable doing that when I do not understand any of the language... so ideally it'd get set up the same as the Chinese translations where there are maintainers that handle the PRs for that language. This PR is the first I'm hearing about any move on this. |
I'll ping @craigbox in the #docs saying we want to start the work, just to make sure we can go ahead. |
I didn't want to lose the motivation of having a contributor who had already translated everything into Ukrainian, so I found another Ukrainian speaker I knew and asked him to give it at least a once-over. I think I generally approve the PRs, but that's really as a one-off for that language, and I'm not working full-time on Istio at present anyway. (Sounds like you're already getting a team together, which is great.) |
p.s. I'm not sure about the value of having a branch (or even sure how you created one!) |
Description
Reviewers