Skip to content

Conversation

grnmeira
Copy link
Contributor

Description

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@grnmeira grnmeira requested a review from a team as a code owner August 20, 2025 12:35
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 20, 2025
@dhawton
Copy link
Member

dhawton commented Aug 20, 2025

This typically comes after the translation? I'm worried about this as it stands the number of docs maintainers we have is very low, do we already have a team that can handle these translations and PR reviews?

@grnmeira
Copy link
Contributor Author

This typically comes after the translation? I'm worried about this as it stands the number of docs maintainers we have is very low, do we already have a team that can handle these translations and PR reviews?

I was basically trying to follow the instructions for translations. I'd expect that we would create a PR into main once we have the translation done in this branch. At the moment we have 3 people (including me) that are willing to work on this. I'd accept other suggestions on how we can progress with an iterative translation.

@dhawton
Copy link
Member

dhawton commented Aug 20, 2025

This typically comes after the translation? I'm worried about this as it stands the number of docs maintainers we have is very low, do we already have a team that can handle these translations and PR reviews?

I was basically trying to follow the instructions for translations. I'd expect that we would create a PR into main once we have the translation done in this branch. At the moment we have 3 people (including me) that are willing to work on this. I'd accept other suggestions on how we can progress with an iterative translation.

I missed this wasn't to the master branch.

In the past it's gone through TOC afaik. Unfortunately, on the infra/English side, we're down to essentially 2 people atm. I think Craig was bottomlining the Ukranian translations, but I don't know if I'm comfortable doing that when I do not understand any of the language... so ideally it'd get set up the same as the Chinese translations where there are maintainers that handle the PRs for that language. This PR is the first I'm hearing about any move on this.

@grnmeira
Copy link
Contributor Author

In the past it's gone through TOC afaik. Unfortunately, on the infra/English side, we're down to essentially 2 people atm. I think
I'll create a PR for teams.yaml today adding the 3 maintainers we have at the moment. We started the discussion here: https://istio.slack.com/archives/C50V5EATT/p1753833333370369?thread_ts=1753728980.344819&cid=C50V5EATT

I'll ping @craigbox in the #docs saying we want to start the work, just to make sure we can go ahead.

@craigbox
Copy link
Contributor

I didn't want to lose the motivation of having a contributor who had already translated everything into Ukrainian, so I found another Ukrainian speaker I knew and asked him to give it at least a once-over.

I think I generally approve the PRs, but that's really as a one-off for that language, and I'm not working full-time on Istio at present anyway.

(Sounds like you're already getting a team together, which is great.)

@craigbox
Copy link
Contributor

p.s. I'm not sure about the value of having a branch (or even sure how you created one!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants