add x-forwarded-host and x-forwarded-port in proxy headers #3532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <[email protected]>
ramaraochavali
added
the
release-notes-none
istio-testing
added
the
size/S
howardjohn
reviewed
Jun 27, 2025
| @@ -740,6 +746,13 @@ message ProxyConfig { | |||
| // requests and automatically normalize headers to lowercase, ensuring compliance with HTTP/2 | |||
| // standards. | |||
| google.protobuf.BoolValue preserve_http1_header_case = 40; | |||
| // Controls the `X-Forwarded-Host` header. If enabled, the `X-Forwarded-Host` header is appended | |||
There was a problem hiding this comment.
This defaults to OFF, right?
If so, we should probably mention that (since most of these are default ON), and maybe flip disabled to enabled so you don't need to do disabled: false?
There was a problem hiding this comment.
Yes. Changed
Signed-off-by: Rama Chavali <[email protected]>
|
@ramaraochavali: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.