Skip to content

add support for additional cookie attributes #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

add support for additional cookie attributes #3521

wants to merge 2 commits into from

Conversation

ramaraochavali
Copy link
Contributor

@ramaraochavali ramaraochavali requested a review from a team as a code owner June 11, 2025 10:42
@ramaraochavali ramaraochavali added the release-notes-none Indicates a PR that does not require release notes. label Jun 11, 2025
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2025
@ramaraochavali ramaraochavali mentioned this pull request Jun 11, 2025
Open
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 17, 2025
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ramaraochavali
update and resolve conflicts
a740318 
Signed-off-by: Rama Chavali <[email protected]>
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2025
@istio-testing
Copy link
Collaborator

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api a740318 link false /test release-notes
build_api a740318 link true /test build
gencheck_api a740318 link true /test gencheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ramaraochavali
Copy link
Contributor Author

I will reopen with a fresh PR

@ramaraochavali ramaraochavali deleted the fix/cookie_attributes branch June 17, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramaraochavali @istio-testing