-
Notifications
You must be signed in to change notification settings - Fork 574
Istio API Feature Status using proto annotations #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// Copyright 2019 Istio Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
syntax = "proto3"; | ||
|
||
package istio.extensions; | ||
|
||
option go_package="istio.io/api/istio.io/extensions"; | ||
|
||
import "google/protobuf/descriptor.proto"; | ||
|
||
// Values applied at the field level | ||
extend google.protobuf.FieldOptions { | ||
IstioFeature feature = 1300; | ||
zhlsunshine marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
enum FeatureStatus { | ||
ALPHA = 0; | ||
zhlsunshine marked this conversation as resolved.
Show resolved
Hide resolved
|
||
BETA = 1; | ||
STABLE = 2; | ||
EXPERIMENTAL = 3; | ||
} | ||
|
||
// These options should be used during schema definition, applying them to some of the fields in protobuf | ||
// Below are 1 related repo and 1 PR for this repo: | ||
// Repo: https://github.com/istio/enhancements | ||
// Repo PR: https://github.com/istio/enhancements/pull/88 | ||
message IstioFeature { | ||
// label the feature's status, available status values may be alpha, beta and stable | ||
// there would be experimental in future. | ||
optional FeatureStatus status = 1; | ||
zhlsunshine marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// id means the feature id which can be mapped here: https://github.com/istio/enhancements/blob/master/features.yaml | ||
// it should be contained in id section of features under this yaml file. | ||
optional string id = 2; | ||
zhlsunshine marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given John's comment below I think this would be best suited as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jacob-delgado okay, I will add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.