Teacher onboarding overview #1559
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## redesign-2024 #1559 +/- ##
=================================================
- Coverage 40.42% 40.27% -0.15%
=================================================
Files 503 511 +8
Lines 22484 22706 +222
Branches 7438 7527 +89
=================================================
+ Hits 9089 9145 +56
- Misses 12761 12931 +170
+ Partials 634 630 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…pp into teacher-onboarding-overview
|
I'm going to put off fixing these tests until we have a decision on how navigation will work. |
…rview [VRT] Update baselines for teacher-onboarding-overview
…/isaac-react-app into teacher-onboarding-overview
| @@ -411,7 +411,7 @@ export const logInUser = (provider: AuthenticationProvider, credentials: Credent | |||
| // requestCurrentUser gives us extra information like auth settings, preferences and time until session expiry | |||
| dispatch(requestCurrentUser() as any); | |||
| dispatch({type: ACTION_TYPE.USER_LOG_IN_RESPONSE_SUCCESS, user: result.data}); | |||
| history.replace(persistence.pop(KEY.AFTER_AUTH_PATH) || "/"); | |||
| history.replace(getAfterAuthPath(result.data)); | |||
There was a problem hiding this comment.
I feel like we should be doing this for MFA users too (but currently don't as they return from the function early). Particularly assuming that at some point in the future we want to open MFA beyond just admin accounts.
There was a problem hiding this comment.
Nice catch, also made me realise we're not doing the right thing for initial signup. I'll address that!
| <Container className="overview-padding mw-1600"> | ||
| <div id={"page-title"} className={"py-3"}> | ||
| <PageTitle currentPageTitle={"Overview"} /> | ||
| </div> |
There was a problem hiding this comment.
I'm not sure that I think this is very important given that other pages don't have this anyway, but the designs include a horizontal bar here. I think it vaguely helps distinguish the heading from subheading. Is it intentionally not included now?
There was a problem hiding this comment.
I noticed we removed the <hr /> from pages on Ada CS in general a while ago, so that's why I didn't include it here.
Adds a new Overview page, which teachers are directed to after sign-in. Also adds this to the navbar.