-
Notifications
You must be signed in to change notification settings - Fork 6
LLM Error & Failure Reporting #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjd210
wants to merge
9
commits into
master
Choose a base branch
from
improvement/llm-failure-reporting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was returning a zero mark response, with no user-facing warning to indicate that it wasn't an issue with their answer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 35.76% 35.88% +0.12%
==========================================
Files 529 529
Lines 23478 23484 +6
Branches 2849 2849
==========================================
+ Hits 8396 8427 +31
+ Misses 14222 14196 -26
- Partials 860 861 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers a few different related changes:
ValidatorUnavailableException
and consequently show a "Your answer could not be checked. Please try again." popup in the frontend.maxMarks
, with appropriate feedback (adapted from Add null checking to LLM Free Text Questions #691)To note - I have left default zero mark results in for cases where the OpenAI client has successfully responded but not in a format we're expecting (either not json, or using more than one message). These cases are not independent from the user's answer since they may have been caused by prompt injection or other unusual input, and we want these types of answers to still receive no marks. In this case I believe it is more helpful than an error, although I'm open to suggestions.