upgrade to fw 4.6.1 and upgrade Unity v4.0.0.0 #2
Conversation
|
Hi! Thanks a lot for this PR. Just a quick question - given that there don't appear to be any code changes - what's the stop leaving it at the current version? You should still be able to use Unity 4 with it, you probably just need a binding redirect or two? |
| /// Initializes a new instance of the CollectionFacade class. | ||
| /// </summary> | ||
| public UnityCollectionFacade(IUnityContainer target) | ||
| { | ||
| resolvedTypes = target.ResolveAll<T>(); |
There was a problem hiding this comment.
Hmmm. Slight change in behaviour here - is there a reason behind this? I suspect what you're proposing is to get the latest version all the time?
There was a problem hiding this comment.
Exactly, resolvedTypes is a local list of the registrations, but will not sync with the container after adding a new registration.
|
Hi Isaac, That was only the reason behind of the FW upgrade. |
|
Hi I want to accept this PR but really first want to see a repro of this issue with the binding redirect to prove that it's necessary. Can you whip up something really small that shows the problem? At any rate, the fix to the Facade class is definitely a good idea and should go in. |
|
@RustyChain I know it's been months, but if you can you give me a simple repro on the binding redirects issue I'll be happy to accept this PR - I just can't repro it myself. |
It was just a simple fw and package update and I'd be happy to release a new version on nuget.
Thanks advanced,
Rusty