Resolve #1601 by avoiding redundant allocations #1606
Conversation
…ach frame * input_frame allocated with align 0 so copy here is unnecessary
Mikhael-Danilov
changed the title
| #include "../toxcore/network.h" | ||
|
|
||
| #define MAX_DECODE_TIME_US 0 /* Good quality encode. */ | ||
| #define MAX_ENCODE_TIME_US ((1000 / 24) * 1000) |
There was a problem hiding this comment.
Would this set the minimum FPS of toxav to 24?
There was a problem hiding this comment.
- It moved from toxav.c as is
- As far as I understand it is a hint for encoder to try maintain 24 fps performance
- Not sure if it is good idea to have this hardcoded but it out of this PR scope
There was a problem hiding this comment.
kk, you're right then, out of scope.
Thanks again for putting so much work into this!
There was a problem hiding this comment.
@GrayHatter So... Would you mind merging it? :) Or you are not the main merger?
There was a problem hiding this comment.
I don't merge anything that doesn't have @irungentoo's sign off. I also
haven't had time to test it so I haven't been bugging him to merge in
either.
@wiiaam @mannol @subliun any of you had a chance to test this yet?
On Jul 22, 2016 03:51, "vassad" [email protected] wrote:
In toxav/video.c
#1606 (comment):@@ -34,6 +34,8 @@
#include "../toxcore/network.h"#define MAX_DECODE_TIME_US 0 /* Good quality encode. */
+#define MAX_ENCODE_TIME_US ((1000 / 24) * 1000)So... Would you mind merging it? :) Or you are not the main merger?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/irungentoo/toxcore/pull/1606/files/185318bbce339f1ee908a46c3f4acfdae93a9198#r71861045,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO20JyofDW4RUAQ5_pnfHcuoH1WZYZOks5qYKCmgaJpZM4JPAmO
.
|
Sadly but looks like we still need frame-data copy here ( only if we not going to provide each libvpx ABI variant using VPX_IMAGE_ABI_VERSION macro ) |
|
anyone still watching this thread, consider opening on https://github.com/TokTok/c-toxcore/ |
3 participants
Resolve #1601 by avoiding redundant allocations