-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add Metal render system for iOS #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
add android ANDROID_APP_*****_STORE_TYPE update android com.android.tools.build:gradle 8.12.2
update android com.devtodev:android-analytics 2.5.1 update android com.google.firebase:firebase-bom 34.2.0
update android com.applovin:applovin-sdk 13.4.0
fix PythonScriptService fix OpenALSoundBufferStream stopSource
improve android use getResourceName
improve android MengineGoogleGameSocialPlugin
add visitAnalyticsParameter
improve iOS Amplitude
fix CMake MENGINE_SOLUTIONS_CONFIG_DIR
improve iOS config ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } catch (IOException ignored) { | ||
| // ignore | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: File logger missing newline between log entries
The writeLine method writes log entries to the file without appending a newline character. This causes all log messages and exceptions to be concatenated on a single line in the log file, making the file unreadable. The method should append \n or use System.lineSeparator() after writing each line to properly separate log entries.
| } | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing null check causes NullPointerException in ad service
The newly added methods isShowingRewarded() and isShowingInterstitial() call methods on m_adProvider without first checking if it's null. Every other method in MengineAdService that uses m_adProvider includes a null check (e.g., hasBanner(), hasInterstitial(), hasRewarded(), showBanner()). When m_adProvider is null (before an ad provider is set), calling these methods will throw a NullPointerException.
Summary
RP_METALrender platformMetalRenderSystemand environment//////////////////////////////////////////////////////////////////////////separators between Metal function implementationsTesting
cmake ../cmake/Unix -DCMAKE_BUILD_TYPE=Debug(fails: miss MENGINE_DEPENDENCIES_PROJECT)https://chatgpt.com/codex/tasks/task_e_68b068b84ed883209599ca7a5c9a28f3
Note
Introduce a functional Metal render system and switch iOS to Metal, alongside broad platform, file I/O, analytics, sound, Box2D, HTTP, and iOS plugin updates.
RP_METALrenderer (buffers, shaders/programs, textures, targets, state, frame ops) and Metal extension hook; migrate iOS windowing to SDL Metal.void; add debug file-path tracking; numerous platform streams (Win32/Apple/Android/SDL2) updated; temp-file move on close.size_tparameter counts; iOS analytics provider category routing.Written by Cursor Bugbot for commit cec40b6. This will update automatically on new commits. Configure here.