ci(dependabot): split /sample gomod entry from /#379
Open
peanball wants to merge 1 commit into
Open
Conversation
The /sample module is a separate entity from the root; grouping both under one gomod block with a k8s.io/* / sigs.k8s.io/* ignore rule can produce inconsistent bumps when sample's deps (via ironcore) transitively require newer k8s versions than the ignore rule allows. Give /sample its own gomod entry with its own group and no ignore list. Signed-off-by: Alexander Lais <alexander.lais@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /sample module is a separate entity from the root; grouping both
under one gomod block with a k8s.io/* / sigs.k8s.io/* ignore rule can
produce inconsistent bumps when sample's deps (via ironcore) transitively
require newer k8s versions than the ignore rule allows.
Give /sample its own gomod entry with its own group and no ignore list.
The inconsistency mentioned above leads to the sample go.mod file not being complete, and the test_openapi_extractor tests action failing.