Skip to content

Conversation

@PlagueCZ
Copy link
Contributor

I added the ability to list all loadbalancer targets and all prefixes (incl. lbprefixes), in the same fashion as previously has been done with NATs, i.e. by specifying an "empty" identifier.

For prefixes, the drawback is that in the response, the VNI is not valid, it is the "empty" one.

  • given the fact that target VNI is always the same as VNI anyway, this is a non-issue

For LB targets, the actual LB id is missing from the output.

  • not ideal, but for checking whether both dpservices are orchestrated the same, this is enough.

Both of the above is easily fixable, but requires changes to the gRPC protocol, which I would rather not do. And given the fact that this already covers the intended purpose (quick check of HA dpservices), the need for the change is low in my opinion.

Fixes #745

@github-actions github-actions bot added size/L enhancement New feature or request labels Nov 15, 2025
@PlagueCZ PlagueCZ force-pushed the feature/list_all_routes_lbtargets branch from b25f1c7 to b0228a4 Compare November 15, 2025 01:02
@guvenc
Copy link
Collaborator

guvenc commented Nov 26, 2025

@PlagueCZ
This looks ok to me. Can we add a pytest test case where the loadbalancer behaviour is already tested, a call which would test the expected behaviour introduced here ?

@PlagueCZ PlagueCZ force-pushed the feature/list_all_routes_lbtargets branch 2 times, most recently from 5fa7835 to a0917ae Compare November 26, 2025 17:17
@PlagueCZ PlagueCZ force-pushed the feature/list_all_routes_lbtargets branch from a0917ae to 4206d31 Compare November 26, 2025 17:24
@PlagueCZ
Copy link
Contributor Author

Added pytest for all lists that have no "native" list call, i.e. use some special nul-value instead to force listing all entries.

@PlagueCZ PlagueCZ marked this pull request as ready for review November 26, 2025 17:28
@PlagueCZ PlagueCZ requested a review from a team as a code owner November 26, 2025 17:28
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the tests as well.

@guvenc guvenc merged commit 4206d31 into main Dec 2, 2025
6 checks passed
@guvenc guvenc deleted the feature/list_all_routes_lbtargets branch December 2, 2025 09:36
@github-project-automation github-project-automation bot moved this to Done in Roadmap Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add ability to list also all routes and lbtargets

4 participants