Skip to content

Integrate torch-mlir at aa74936c #19979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

bjacob
Copy link
Contributor

@bjacob bjacob commented Feb 13, 2025

No description provided.

Signed-off-by: Benoit Jacob <[email protected]>
@bjacob bjacob marked this pull request as ready for review February 14, 2025 02:11
@bjacob
Copy link
Contributor Author

bjacob commented Feb 14, 2025

@ScottTodd , this turns out not to make a difference to ONNX tests.

@bjacob bjacob requested a review from ScottTodd February 14, 2025 02:12
@ScottTodd
Copy link
Member

@ScottTodd , this turns out not to make a difference to ONNX tests.

Oh, @zjgarvey reported that they passed: llvm/torch-mlir#3945 (comment). Hmm..

@bjacob bjacob merged commit b31b408 into iree-org:main Feb 14, 2025
40 checks passed
@zjgarvey
Copy link
Contributor

@ScottTodd , this turns out not to make a difference to ONNX tests.

Oh, @zjgarvey reported that they passed: llvm/torch-mlir#3945 (comment). Hmm..

I'll take another look. Tests like "onnx/node/generated/test_resize_downsample_scales_linear" should definitely pass.

@bjacob
Copy link
Contributor Author

bjacob commented Feb 14, 2025

Maybe I am misinterpreting CI? All I know is, CI just passed on this PR. I was expecting it to fail due to expected-to-fail tests now passing.

@zjgarvey
Copy link
Contributor

zjgarvey commented Feb 14, 2025

Yeah, I just re-ran all of the resize tests on iree/main and the ones you had to fail on the last bump are now passing. Will locally revert this bump and see if they fail for me. Not sure what's going on.

@zjgarvey
Copy link
Contributor

Reverting this commit locally resulted in only 7 passes, so I'm a bit stumped on why the CI didn't complain about the newly passing tests. I'll try to take a closer look tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants